Skip to content

MenuItem (GTK): allow additional shortcut words #1852 #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

MenuItem (GTK): allow additional shortcut words #1852 #2173

merged 1 commit into from
Jun 18, 2025

Conversation

@tmssngr
Copy link
Contributor

@tmssngr tmssngr commented May 21, 2025

This allows to use more shortcuts to be displayed for a menu item, e.g. Ctrl+Keypad + or Alt+Down.

@tmssngr tmssngr force-pushed the feature/gtk-menuitem-allow-more-shortcuts branch from 33522ef to 879f096 Compare May 21, 2025 09:33
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2025 •
edited
Loading

Test Results

   539 files  ±0     539 suites  ±0   28m 39s ⏱️ - 5m 51s
 4 364 tests ±0   4 348 ✅ ±0   15 💤 ±0  0 ❌ ±0  1 🔥 ±0 
16 691 runs  ±0  16 553 ✅ ±0  137 💤 ±0  0 ❌ ±0  1 🔥 ±0 

For more details on these errors, see this check.

Results for commit fe6e0f0. ± Comparison against base commit 7ad8ef2.

♻️ This comment has been updated with latest results.

@tmssngr tmssngr force-pushed the feature/gtk-menuitem-allow-more-shortcuts branch 2 times, most recently from 9585793 to 6f51466 Compare May 21, 2025 11:43
@tmssngr
Copy link
Contributor Author

tmssngr commented May 22, 2025

@akurtakov Would you like to review this PR?

@akurtakov
Copy link
Member

akurtakov commented May 22, 2025

We are past final build for rc1. I will review it when next cycle opens.

@tmssngr tmssngr mentioned this pull request May 24, 2025
Closed
@akurtakov akurtakov force-pushed the feature/gtk-menuitem-allow-more-shortcuts branch 2 times, most recently from a47e852 to 77ce751 Compare June 9, 2025 04:40
tmssngr pushed a commit to syntevo/eclipse.platform.swt that referenced this pull request Jun 16, 2025
Pull Request eclipse-platform#2173: MenuItem (GTK): allow additional …
67d35d4 
…shortcut words eclipse-platform#1852
@tmssngr tmssngr force-pushed the feature/gtk-menuitem-allow-more-shortcuts branch 2 times, most recently from 67d35d4 to 6dc19cc Compare June 16, 2025 12:59
@akurtakov
Copy link
Member

akurtakov commented Jun 16, 2025 •
edited
Loading

It would be nice to have a test for these.

eclipse.platform.swt/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_MenuItem.java

Line 262 in 7add671

public void test_setTextLjava_lang_String() {
looks like the place to add them.

@akurtakov
Copy link
Member

akurtakov commented Jun 16, 2025

A new test method might be good too(depends on how big it the test will be).

@akurtakov
Copy link
Member

akurtakov commented Jun 16, 2025

#2240 makes the test slightly more straightforward.

@akurtakov akurtakov force-pushed the feature/gtk-menuitem-allow-more-shortcuts branch from 6dc19cc to ec09873 Compare June 18, 2025 04:34
@tmssngr tmssngr force-pushed the feature/gtk-menuitem-allow-more-shortcuts branch from ec09873 to fe6e0f0 Compare June 18, 2025 09:01
@tmssngr
Copy link
Contributor Author

tmssngr commented Jun 18, 2025

Yes, a test would be fine. Do you suggest to make MenuItem.MaskKeysym and getMaskKeysym more visible to test it?

@akurtakov
Copy link
Member

akurtakov commented Jun 18, 2025

My bad. Opening more for testing shouldn't happen. I'll merge the patch as is. Thanks!

@akurtakov akurtakov merged commit cad131b into eclipse-platform:master Jun 18, 2025
15 of 17 checks passed
@guiv42 guiv42 mentioned this pull request Jun 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmssngr @akurtakov